Fix test_file_checker in check_mtime case #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotacarma90
force-pushed
the
4839-check-mtime-false-negative
branch
from
55d4928
to
fc822cf
Compare
jotacarma90
force-pushed
the
4839-check-mtime-false-negative
branch
from
fc822cf
to
9a0bb45
Compare
jotacarma90
force-pushed
the
4839-check-mtime-false-negative
branch
from
9a0bb45
to
885904c
Compare
juliamagan
requested changes
Jan 19, 2024
tests/integration/test_fim/test_files/test_file_checks/test_file_checkers.py
Show resolved
Hide resolved
juliamagan
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
The regular_file_cud function does too many things, it is practically the whole test. The best solution would be to refactor this function to be able to split the different tasks, but this would affect most of the FIM tests, and knowing that these tests will be deprecated in the future and worked on by the core team to implement them in GitHub Actions, we can accept this solution.
lchico
reviewed
Jan 22, 2024
tests/integration/test_fim/test_files/test_file_checks/test_file_checkers.py
Show resolved
Hide resolved
lchico
requested changes
Jan 22, 2024
jotacarma90
force-pushed
the
4839-check-mtime-false-negative
branch
from
885904c
to
37ed788
Compare
jotacarma90
force-pushed
the
4839-check-mtime-false-negative
branch
from
37ed788
to
6de68b4
Compare
MarcelKemp
approved these changes
Jan 24, 2024
juliamagan
approved these changes
Jan 24, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix some false negative cases that were coming up in the
test_file_checkers.This test configures a Wazuh directory with
check_all=noandcheck_mtime=yesso only thetimestampwill be taken into account by FIM to see if there have been changes in the file. And if it coincides that the added and the modified happen in the same second (same timestamp), the modification event is not detected and that's why the test fails.To solve it I have included a sleep of one second after the creation of the file for the case of the
check_mtime. This way we make sure that the timestamp of the event is different and we get correctly the alert.Jenkins build success:
https://ci.wazuh.info/job/Test_integration/45871/