-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to stretch, ensure ssl-dev is installed #2131
base: master
Are you sure you want to change the base?
bump to stretch, ensure ssl-dev is installed #2131
Conversation
4c5ee2f
to
bf27bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution.
- Regarding the changes referring to the AMD64 Dockerfile, they seem correct to me since for consistency with the other Dockerfiles the package should be built in the same system (Debian Stretch) and therefore, the dependency changes should be consistent.
- Regarding specifying the platform flag, I ask you for consistency either all Dockerfiles use
--platform
or use the formatarchitecture/debian:stretch
- Regarding the
libssl1.0-dev
package we must validate if it is really necessary, according to the documentation, thelibssl-dev
package should be installed
In any case, it is necessary to share a full build output of an ARM64 and AMD64 package build with the new Dockerfiles in order to be accepted.
Regarding the node package, it is used in the construction of the Wazuh API, which has already been deprecated, I will ask the team why this package is still present and we will create an issue if it should be removed.
@@ -1,18 +1,19 @@ | |||
FROM debian:7 | |||
FROM --platform=linux/amd64 debian:stretch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, please use the flag --platform
or use the format architecture/debian:stretch
in all Debian Dockerfiles
autoconf libtool libaudit-dev selinux-basics \ | ||
libdb5.3 libdb5.3 libssl1.0.2 libssl1.0-dev gawk libsigsegv2 | ||
|
||
# Add Debian's source repository and, Install NodeJS 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment
Description
wheezy GPG keys have expired, and building for AMD64 no longer works.
This bumps the amd64 docker image to match the arm64 (ARM) one for the most part.
I'm unclear why
node
is needed for the arm64 build. Building amd64 worked without it.This also adds the
--platform
flag to slightly better support Apple M1 Rossetta and cross compiling.Logs example
Current
master
:note:
W: GPG error: http://archive.debian.org wheezy Release: The following signatures were invalid: KEYEXPIRED 1587841717 KEYEXPIRED 1668891673 KEYEXPIRED 1557241909
Tests
%files
section is correctly updated if necessary%files
section is correctly updated if necessary