Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the actions' version #6

Merged

Conversation

guidomodarelli
Copy link

@guidomodarelli guidomodarelli commented Nov 7, 2024

Description

Several warnings are generated when executing GitHub Workflows, primarily due to the utilization of deprecated versions of GitHub Actions. Upgrading to the latest version resolves these warnings and is a straightforward process.

Issues Resolved

Closes wazuh/wazuh-dashboard#345

Evidence

Here is why I removed the filter option.

image

5ff69e4#diff-f258144e908ac90eebcd80eeb5191a1007b50b9c0ca74325497c2e8d4e666f99L87-L89

5ff69e4#diff-ce491377e1248da0574b2312a9960bc2bc35a6e828452954b56176e1347354edL87-L89

Changelog

  • chore: update the actions' version accordingly.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@guidomodarelli guidomodarelli self-assigned this Nov 7, 2024
…ieval settings for improved flexibility in workflows
…kflows for improved reliability in OpenSearch download
…r improved reliability in OpenSearch artifact downloads
…ypress and ftr workflows to avoid redundant downloads
…g OpenSearch artifacts in cypress and ftr workflows
…press and ftr workflows by removing existence checks
…in dashboards reports test and build workflow
…ng in dashboards reports test and build workflow
…rd setup in binary installation verification workflow
@yenienserrano
Copy link
Member

The issue it says to update the GitHub actions but I see that you are updating all of them, was this for some reason?

@guidomodarelli
Copy link
Author

The issue it says to update the GitHub actions but I see that you are updating all of them, was this for some reason?

Since I'm modifying the versions, I checked all the files to take advantage of the opportunity

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit 1164c4b into master Nov 8, 2024
7 of 11 checks passed
@Tostti Tostti deleted the change/345-use-of-deprecated-actions-on-gh-workflows branch November 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of deprecated Actions on GH Workflows
3 participants