Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification plugin registered in the Explore category #422

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 19, 2024

Description

Fixed Notification category registration to be displayed in Explore category

Issues Resolved

Testing requirements

Generate 4.10.0 packages from all repositories that involve Wazuh-dashboard or download them from the action

https://github.com/wazuh/wazuh-dashboard/actions/runs/11742411861

Test

  1. Execute the script dev-tools/build-packages/base/generate_base.sh.
  2. Install the generated package and check that the notification plugin is registered in the explore category.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Nov 19, 2024
@yenienserrano yenienserrano linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image
image
image

CR 🟢

LGTM!!

Copy link

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫: The test hasn't started yet
🟢: All checks passed.
🟡: There is at least one expected fail or skipped test and no failures.
🔴: There is at least one failed check.
⚪: Doesn't apply

CR 🟢
TEST 🟢

image

image

@Desvelao Desvelao merged commit 21d94de into 4.10.0 Nov 20, 2024
60 of 62 checks passed
@Desvelao Desvelao deleted the bug/421-fix-notifications-plugin-registered-category-to-explore branch November 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Notifications plugin registered category to Explore
4 participants