-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tar error in build workflow #168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.9.0 #168 +/- ##
===========================================
- Coverage 66.96% 43.87% -23.10%
===========================================
Files 3300 1570 -1730
Lines 63585 31644 -31941
Branches 10141 6002 -4139
===========================================
- Hits 42582 13884 -28698
+ Misses 18538 16721 -1817
+ Partials 2465 1039 -1426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR aims to fix a tar error that is visible when running the package build workflow.
Additionally, it adds error controls to abort the building process if a plugin is not correctly installed
Issues Resolved
#167
Evidence
Now the workflow fails if a plugin is not correctly installed, and the stdout error is no longer present
Check List
yarn test:jest
yarn test:jest_integration