Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar error in build workflow #168

Merged
merged 12 commits into from
Apr 17, 2024
Merged

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 16, 2024

Description

This PR aims to fix a tar error that is visible when running the package build workflow.

Additionally, it adds error controls to abort the building process if a plugin is not correctly installed

Issues Resolved

#167

Evidence

Now the workflow fails if a plugin is not correctly installed, and the stdout error is no longer present
image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti linked an issue Apr 16, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.87%. Comparing base (f066302) to head (36f557d).
Report is 2 commits behind head on 4.9.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##            4.9.0     #168       +/-   ##
===========================================
- Coverage   66.96%   43.87%   -23.10%     
===========================================
  Files        3300     1570     -1730     
  Lines       63585    31644    -31941     
  Branches    10141     6002     -4139     
===========================================
- Hits        42582    13884    -28698     
+ Misses      18538    16721     -1817     
+ Partials     2465     1039     -1426     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Windows_1 ?
Windows_2 ?
Windows_3 43.87% <ø> (ø)
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit 477276f into 4.9.0 Apr 17, 2024
7 of 102 checks passed
@Tostti Tostti deleted the 167-fix-tar-error-in-build-workflow branch April 17, 2024 20:24
Tostti added a commit that referenced this pull request Apr 17, 2024
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tar error in the package build workflow
3 participants