Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script test packages #133

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 22, 2023

Description

Tests are added for the packages that create the actions

Test

https://github.com/wazuh/wazuh-dashboard/actions/runs/7347461142

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Dec 22, 2023
@yenienserrano yenienserrano linked an issue Dec 22, 2023 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd4fe7a) 66.82% compared to head (3656a92) 66.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           2.11.1     #133      +/-   ##
==========================================
- Coverage   66.82%   66.82%   -0.01%     
==========================================
  Files        3284     3284              
  Lines       63180    63180              
  Branches    10051    10051              
==========================================
- Hits        42223    42221       -2     
- Misses      18480    18481       +1     
- Partials     2477     2478       +1     
Flag Coverage Δ
Linux_1 35.25% <ø> (ø)
Linux_2 55.23% <ø> (ø)
Linux_3 43.83% <ø> (-0.01%) ⬇️
Linux_4 35.47% <ø> (ø)
Windows_1 35.27% <ø> (ø)
Windows_2 55.19% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yenienserrano yenienserrano changed the title Add script test files exist and owner Add script test packages Dec 26, 2023
@yenienserrano yenienserrano marked this pull request as ready for review December 28, 2023 15:27
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️

LGTM 🟢

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

LGTM

@Tostti Tostti merged commit 942ecfb into 2.11.1 Jan 2, 2024
117 of 118 checks passed
@Tostti Tostti deleted the 132-generate-testing-for-packages branch January 2, 2024 19:10
yenienserrano added a commit that referenced this pull request Feb 21, 2024
Tostti pushed a commit that referenced this pull request Apr 5, 2024
yenienserrano added a commit that referenced this pull request Jun 18, 2024
yenienserrano added a commit that referenced this pull request Jul 12, 2024
yenienserrano added a commit that referenced this pull request Aug 19, 2024
yenienserrano added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate testing for packages
4 participants