Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating our package construction methods #122

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 21, 2023

Description

Updating our package construction methods to support different applications.

Issues Resolved

Prerequisites

You need a package of wazuh-dashboard, wazuh-dashboard-plugins and security plugin generated by the build actions from github

Test

  • Create wazuh-dashboard-base
  1. Have created packages of all plugins and wazuh dashboard, you can use the packages created from the github actions

If you want, you can use these packages:

Download them and use first the script to generate the base or the script you decide which package to create.

2a. Generate base

./generate_base.sh -v <version> -r <revision> -a <wazuh-packages>.zip -s <wazuh-security-dashboards-plugin>.zip -b <wazuh-dashboard>.zip 

3a. Create packages .deb .rpm

./launcher.sh -v version -p <base_package> -r <revision> 

2b. Generate all packages

 bash ./build-packages.sh -a <wazuh-package>.zip -s <wazuh-security-dashboards-plugin>.zip -b <wazuh-dashboard>.zip -v <version> -r <revision>  <--all-platform | --tar | --rpm | --deb>

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano changed the title Update generate_base.sh to support Wazuh applications and use packages downloaded from github actions Updating our package construction methods Nov 21, 2023
@yenienserrano yenienserrano self-assigned this Nov 21, 2023
@yenienserrano yenienserrano linked an issue Nov 21, 2023 that may be closed by this pull request
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3b228c) 66.80% compared to head (1a10804) 66.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            4.9.0     #122   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files        3284     3284           
  Lines       63162    63162           
  Branches    10051    10051           
=======================================
+ Hits        42193    42196    +3     
+ Misses      18496    18495    -1     
+ Partials     2473     2471    -2     
Flag Coverage Δ
Linux_1 35.27% <ø> (ø)
Linux_2 55.27% <ø> (ø)
Linux_3 43.84% <ø> (+<0.01%) ⬆️
Linux_4 35.48% <ø> (+<0.01%) ⬆️
Windows_1 35.28% <ø> (ø)
Windows_2 55.23% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yenienserrano yenienserrano marked this pull request as ready for review November 24, 2023 15:55
@yenienserrano yenienserrano marked this pull request as draft December 1, 2023 16:03
@yenienserrano yenienserrano marked this pull request as ready for review December 4, 2023 12:27
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ✔️
CR ✔️

LGTM

@Tostti Tostti merged commit 1047ad5 into 4.9.0 Dec 5, 2023
96 checks passed
@Tostti Tostti deleted the 119-update-packages-generation-tools branch December 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update packages generation tools I
3 participants