Skip to content

Commit

Permalink
Rename of the artifact uploaded to action (#420)
Browse files Browse the repository at this point in the history
  • Loading branch information
yenienserrano authored Nov 19, 2024
1 parent 86717d0 commit e4a59b0
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_wazuh_dashboard_with_plugins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ jobs:
- uses: actions/upload-artifact@v3
if: success()
with:
name: ${{ needs.setup-variables.outputs.PACKAGE_NAME }}
name: ${{ needs.setup-variables.outputs.FINAL_NAME }}
path: ${{ needs.setup-variables.outputs.CURRENT_DIR }}/dev-tools/build-packages/output/${{needs.setup-variables.outputs.FINAL_NAME}}
retention-days: 30

Expand Down
2 changes: 1 addition & 1 deletion src/core/public/chrome/ui/header/header_logo.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ describe('Header logo', () => {
component.find('.logoContainer img').simulate('click');

expect(props.navigateToApp).toHaveBeenCalledTimes(1);
expect(props.navigateToApp).toHaveBeenCalledWith('wz-home');
expect(props.navigateToApp).toHaveBeenCalledWith('home');
});

// ToDo: Add tests for onClick
Expand Down
2 changes: 1 addition & 1 deletion src/core/public/chrome/ui/header/home_loader.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Home loader', () => {
expect(homeIcon.exists()).toBeTruthy();
homeIcon.simulate('click');
expect(props.navigateToApp).toHaveBeenCalledTimes(1);
expect(props.navigateToApp).toHaveBeenCalledWith('wz-home');
expect(props.navigateToApp).toHaveBeenCalledWith('home');
});
});
});
4 changes: 2 additions & 2 deletions test/functional/apps/home/_home.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await globalNav.clickLogo();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

it('clicking on home button should take you to home page', async () => {
await PageObjects.common.navigateToApp('settings');
await globalNav.clickHomeButton();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

// Wazuh: The home page of Wazuh is different from the OpenSearch Dashboards home page
Expand Down
8 changes: 4 additions & 4 deletions test/functional/apps/visualize/_custom_branding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await globalNav.clickLogo();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

it('with customized mark logo button that navigates to home page', async () => {
await PageObjects.common.navigateToApp('settings');
await globalNav.clickHomeButton();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

// Wazuh: This test is omitted because OpenSearch Dashboards does not have a home dashboard card.
Expand Down Expand Up @@ -211,15 +211,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await globalNav.clickLogo();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

it('with customized mark logo button that navigates to home page', async () => {
await PageObjects.common.navigateToApp('settings');
await globalNav.clickHomeButton();
await PageObjects.header.waitUntilLoadingHasFinished();
const url = await browser.getCurrentUrl();
expect(url.includes('/app/wz-home')).to.be(true);
expect(url.includes('/app/home')).to.be(true);
});

// Wazuh: This test is omitted because OpenSearch Dashboards does not have a home dashboard card.
Expand Down

0 comments on commit e4a59b0

Please sign in to comment.