Skip to content

Commit

Permalink
Change default theme (#174)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tostti authored and yenienserrano committed Oct 28, 2024
1 parent d6a0bd9 commit 7ac788d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest] #Removed 'windows-latest'
group: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13]
group: [1, 2, 4, 5, 6, 7, 8, 9, 10, 11, 13]
include:
- os: ubuntu-latest
name: Linux
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-ui-shared-deps/theme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type Theme = typeof LightTheme;
// in the OpenSearch Dashboards app we can rely on this global being defined, but in
// some cases (like jest) the global is undefined
export const tag: string = globals.__osdThemeTag__;
const themeVersion = tag?.replace(/(light|dark)$/, '') || 'v8';
const themeVersion = tag?.replace(/(light|dark)$/, '') || 'v7';
export const version = parseInt(themeVersion.replace(/[^\d]+/g, ''), 10) || 8;
export const darkMode = tag?.endsWith?.('dark');

Expand Down
2 changes: 1 addition & 1 deletion src/core/server/ui_settings/settings/theme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const getThemeSettings = (): Record<string, UiSettingsParams> => {
defaultMessage: 'Theme version',
}),
value:
DEFAULT_THEME_VERSION === 'v8'
DEFAULT_THEME_VERSION === 'v7'
? themeVersionLabelMap[DEFAULT_THEME_VERSION]
: DEFAULT_THEME_VERSION,
type: 'select',
Expand Down
2 changes: 1 addition & 1 deletion src/core/server/ui_settings/ui_settings_config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const deprecations: ConfigDeprecationProvider = ({ unused, renameFromRoot }) =>
renameFromRoot('server.defaultRoute', 'uiSettings.overrides.defaultRoute'),
];

export const DEFAULT_THEME_VERSION = 'v8';
export const DEFAULT_THEME_VERSION = 'v7';

/* There are 4 levels of uiSettings:
* 1) defaults hardcoded in code
Expand Down

0 comments on commit 7ac788d

Please sign in to comment.