-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend http client #7000
Draft
Desvelao
wants to merge
10
commits into
master
Choose a base branch
from
enhancement/6959-extract-common-services-frontend-http
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add frontend http client #7000
Desvelao
wants to merge
10
commits into
master
from
enhancement/6959-extract-common-services-frontend-http
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create HTTP client based on old services - Create HTTP client request interceptor: request - Create HTTP client generic: GenericRequest - Create HTTP client server: WzRequest, ApiCheck and WzAuthentication - Enhance server API backend client See #6995 - Rename ILogger type to Logger
6 tasks
warn: console.warn, | ||
}; | ||
// No operation logger | ||
const noopLogger = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a new file for each Logger
inside the new folder called logger
.
Comment on lines
+23
to
+45
interface WzRequestServices { | ||
request: HTTPClientRequestInterceptor['request']; | ||
getURL(path: string): string; | ||
getTimeout(): Promise<number>; | ||
getServerAPI(): string; | ||
} | ||
|
||
interface ServerAPIResponseItems<T> { | ||
affected_items: Array<T>; | ||
failed_items: Array<any>; | ||
total_affected_items: number; | ||
total_failed_items: number; | ||
} | ||
|
||
interface ServerAPIResponseItemsData<T> { | ||
data: ServerAPIResponseItems<T>; | ||
message: string; | ||
error: number; | ||
} | ||
|
||
export interface ServerAPIResponseItemsDataHTTPClient<T> { | ||
data: ServerAPIResponseItemsData<T>; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move this interfaces to the types.ts
file.
- Add TableData component (based on TableData of main plugin) - Add ServerTable component (based on TableWzAPI of main plugin) - Add SearchBar (copied from main plugin) - Add FileSaver (copied from main plugin)
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
http
client to thewazuh-core
plugin and expose it to manage the API requests that is a composition of old services:Moreover,
wazuh
plugin)wazuh
plugin)Issues Resolved
#6959
Evidence
Test
Check List
yarn test:jest