Add configuration methods #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebits
requested changes
Jun 28, 2023
Comment on lines
15
to
+24
| DEFAULT_INSTALL_PATH = { | ||
| 'linux': '/var/ossec', | ||
| 'windows': 'C:\\Program Files\\ossec-agent', | ||
| 'windows': 'C:/Program Files (x86)/ossec-agent', | ||
| 'darwin': '/Library/Ossec' | ||
| } | ||
|
|
||
| DEFAULT_TEMPORAL_DIRECTORY = { | ||
| 'linux': '/tmp', | ||
| 'windows': 'C:/Users/qa/AppData/Local/Temp' | ||
| } |
There was a problem hiding this comment.
These vars should be moved into a common variables module
There was a problem hiding this comment.
As the development can be long and goes out of the scope of this PR, the following issue has been created and will be worked on:
Comment on lines
27
to
50
| def configure_local_internal_options(new_conf): | ||
| local_internal_configuration_string = '' | ||
| for option_name, option_value in new_conf.items(): | ||
| local_internal_configuration_string += f"{str(option_name)}={str(option_value)}\n" | ||
| return local_internal_configuration_string | ||
|
|
||
|
|
||
| def configure_ossec_conf(new_conf, template): | ||
| new_configuration = ''.join(set_section_wazuh_conf(new_conf, template)) | ||
| return new_configuration | ||
|
|
||
|
|
||
| def configure_api_yaml(new_conf): | ||
| new_configuration = yaml.dump(new_conf) | ||
| return new_configuration | ||
|
|
||
|
|
||
| conf_functions = { | ||
| 'local_internal_options.conf': configure_local_internal_options, | ||
| 'ossec.conf': configure_ossec_conf, | ||
| 'agent.conf': configure_ossec_conf, | ||
| 'api.yaml': configure_api_yaml | ||
| } | ||
|
|
There was a problem hiding this comment.
We should move all these functions to the configuration module.
Functions to get the directory path should be moved to a separate module too.
| @@ -340,7 +371,7 @@ def get_ruleset_directory_path(self, host): | |||
|
|
|||
| return ruleset_directory_path | |||
|
|
|||
| def configure_host(self, host, configuration_host): | |||
| def configure_host(self, host, configuration_file, configuration_values): | |||
There was a problem hiding this comment.
Update the examples in the docstring
| parameters = {'new_conf': configuration_values} | ||
|
|
||
| # Get template for ossec.conf and agent.conf | ||
| if configuration_file == 'ossec.conf' or configuration_file == 'agent.conf': |
There was a problem hiding this comment.
Suggested change
| if configuration_file == 'ossec.conf' or configuration_file == 'agent.conf': | |
| if configuration_file in ['ossec.conf', 'agent.conf']: |
We can also move that list into a variable called xml_configuration_files
BelenValdivia
suggested changes
Jul 7, 2023
QU3B1M
reviewed
Jul 25, 2023
QU3B1M
approved these changes
Aug 2, 2023
|
LGTM! 🚀 |
|
LGTM! |
BelenValdivia
approved these changes
Aug 2, 2023
davidjiglesias
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, functions have been added that will be used for the configuration of Wazuh nodes. This configuration can be done either in parallel or not.
The following functions have been added which are responsible for modifying and restoring the configuration:
configure_host().change_agents_configured_manager().backup_host_configuration().restore_host_backup_configuration()In addition, the following functions have been added, which are responsible for executing the above functions in parallel when desired:
configure_environment().backup_environment_configuration().restore_environment_backup_configuration().The configuration expected by these functions will have the following format:
The supported files are
ossec.conf,agent.conf,api.yamlandagent.conf