Skip to content

Commit

Permalink
style: isort and black code styling
Browse files Browse the repository at this point in the history
  • Loading branch information
waza-ari committed Jan 8, 2024
1 parent b9292c9 commit ff5b727
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion KNOWN_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ here so we can track them and remove when fixed on EV side

- The API does not offer a simple way to ensure that a custom field is set to a certain value for member. You have to either create (POST) a member_custom_field if the member has no relation to a certain custom field yet, or modify an existing one (PATCH) if there is such a relation. Before modifying a value you therefore have to know if such a relation exists or not.
- When deleting a custom field, the relation between the member and a custom field still stays intact, just with `customField` set to `None`. The tests therefore manually delete member custom field associations before deleting the actual custom field definition to not pollute the test tenant.
- Apparently "path" doesn't mean, that is always will be a HTTP URL. In some cases it has been reported that the path is a local file path, following the `<member_number>_<firstname>_<lastname>/<random_number>_<member_number>-SEPA-Mandat_,,,` syntax. My assumption is that those paths have been used before the introduction of S3 storage on EV side. As I couldn't find any documentation around the naming standard, nor find any information how to actually work with these fields, we're simply adding a string fallback.
- Apparently "path" doesn't mean, that is always will be a HTTP URL. In some cases it has been reported that the path is a local file path, following the `<member_number>_<firstname>_<lastname>/<random_number>_<member_number>-SEPA-Mandat_,,,` syntax. My assumption is that those paths have been used before the introduction of S3 storage on EV side. As I couldn't find any documentation around the naming standard, nor find any information how to actually work with these fields, we're simply adding a string fallback.
2 changes: 1 addition & 1 deletion easyverein/models/base.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from pydantic import Field, PositiveInt

from .mixins.empty_strings_mixin import EmptyStringsToNone
from ..core.types import DateTime, EasyVereinReference
from .mixins.empty_strings_mixin import EmptyStringsToNone


class EasyVereinBase(EmptyStringsToNone):
Expand Down
4 changes: 2 additions & 2 deletions easyverein/models/contact_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

from typing import Any, Literal

from pydantic import Field, EmailStr
from pydantic import EmailStr, Field

from ..core.types import Date, DateTime
from .base import EasyVereinBase
from .mixins.required_attributes import required_mixin
from ..core.types import Date, DateTime


class ContactDetails(EasyVereinBase):
Expand Down
2 changes: 1 addition & 1 deletion easyverein/models/member.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

from pydantic import Field, PositiveInt

from ..core.types import AnyHttpURL, Date, DateTime, EasyVereinReference
from .base import EasyVereinBase
from .mixins.required_attributes import required_mixin
from ..core.types import AnyHttpURL, Date, DateTime, EasyVereinReference


class Member(EasyVereinBase):
Expand Down

0 comments on commit ff5b727

Please sign in to comment.