PHP 8.0 | 8.1 support with tests coverage #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ybelenko, your contribution is welcome! I've taken over the maintenance for this project and one main task is to upgrade it for PHP8 compatibility (along with monolog v3). I'm closing this pull request in favor of #47. If you feel something is missing there please feel free to create a pull request towards https://github.com/waza-ari/monolog-mysql/tree/v2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faced really frustrating bug using package(PDO notice about arguments count mismatch) so I spent a day to cover main class(
MySQLHandler) with unit tests. I was able to achieve 100% test coverage. Hope it means something.It's hard to say whether we need extra major tag(
3.0.0) at 0b7ca19 for PHP 8.1. Probably 96a2949 should be tagged as2.0.0then Composer must resolve appropriate Monolog version.P.S. still not sure that my own bug has been fixed 🤣 Version installed via Composer command (
^1.0.6) has significant differences with latestmaster.