Improve way of populating smtp key/cert to avoid TypeError in py>=12 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 93.67% 93.92% +0.25%
==========================================
Files 9 9
Lines 585 593 +8
==========================================
+ Hits 548 557 +9
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
tkzt
force-pushed
the
fix/improve-key_cert-populating
branch
from
59589ba to
306d5a6
Compare
tkzt
force-pushed
the
fix/improve-key_cert-populating
branch
8 times, most recently
from
29f1192 to
b31ca03
Compare
tkzt
force-pushed
the
fix/improve-key_cert-populating
branch
from
b31ca03 to
94bc835
Compare
greyli
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67