feat: Add support for table alias when injecting ONLY clause #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, great library. We've just recently been using it in production and are really enjoying it.
One thing I've noticed is that Hoardable is not correctly injecting the
ONLY
clause when using a table alias.For example - using the test DB schema as an example:
When building a query using this alias, the
ArelVisitors
monkey patch is silently ignoring it becauseo.left
is a table alias, which needs to be recursed into.Anyway, here is a PR to fix that so Hoardable can properly support using aliases. 👍