Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support variables nested in query when making private queries #39

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mjfaga
Copy link
Collaborator

@mjfaga mjfaga commented Feb 9, 2024

Description

Add support for nested variables when executing "private" queries in order to respect seed requests.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@mjfaga mjfaga requested review from finn-orsini and a team as code owners February 9, 2024 02:33
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea9fa13) 94.43% compared to head (4cdd224) 94.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   94.43%   94.59%   +0.16%     
==========================================
  Files          13       13              
  Lines         503      518      +15     
  Branches      152      154       +2     
==========================================
+ Hits          475      490      +15     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjfaga mjfaga force-pushed the mfaga-support-nested-variables branch from 55f1888 to 4cdd224 Compare February 9, 2024 02:37
@mjfaga mjfaga merged commit 61d30cd into main Feb 9, 2024
7 checks passed
@mjfaga mjfaga deleted the mfaga-support-nested-variables branch February 9, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants