Merge pull request #31 from wayfair-incubator/handle_null_args

fix: handle null args
wayfair-incubator · Aug 21, 2023 · 76c9190 · 76c9190
2 parents 8cac819 + b4c0552
commit 76c9190
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,12 @@ and this project adheres to
 
 ## [Unreleased]
 
+## [v1.1.2] - 2023-08-21
+
+### Fixed
+
+- fix: handle null arguments
+
 ## [v1.1.1] - 2023-08-09
 
 ### Fixed

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@wayfair/gqmock",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "GQMock - GraphQL Mocking Service",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/seed/SeedManager.ts b/src/seed/SeedManager.ts
@@ -117,7 +117,8 @@ export default class SeedManager {
   ) {
     const argsMatch = Object.entries(source).every(
       ([argumentName, argumentValue]) => {
-        if (typeof argumentValue === 'object') {
+        // null is an object, exclude it from this check
+        if (typeof argumentValue === 'object' && argumentValue != null) {
           return this.matchArguments(argumentValue, target[argumentName]);
         }
         return isEqual(target[argumentName], argumentValue);
@@ -130,7 +131,8 @@ export default class SeedManager {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private argumentCount(args: Record<string, any>) {
     return Object.entries(args).reduce((acc, [, value]) => {
-      if (typeof value === 'object') {
+      // null is an object,  exclude it from this check
+      if (typeof value === 'object' && value != null) {
         return acc + this.argumentCount(value) + 1;
       }