-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Debian install and add F-Droid install instruction #71
base: master
Are you sure you want to change the base?
Conversation
Instead of a curl we can use the wget that is always installed on all Debian systems. But since the curl is needed inside of the installation script we still need to install it before. We may get rid of it later. The wget uses the -nv flag to not show a progress but show any errors. The script is downloaded first to temp folder and only then being executed. This protects us from executing partially downloaded file. Instead of piping we executing a bash with the file name and once executed it will be removed.
Add waydroid app list command. Extend example of installing F-Droid.
@aleasto could you please review? |
I think the install and run apps section would need to be split into a purely CLI approach and a purely graphical approach:
I don't like |
I made the changes because I experienced a real problems that tried to fix.
E.g. as you may see I got a progress and then it stuck. Once I pressed ^C it printed:
Now I see the password prompt but in some weird place. The simplest solution is to just a hide the progress (-s Silent or quiet mode. -S When used with -s it makes curl show an error message if it fails):
But technically speaking we still have two issues (both are unlikely):
So instead to just make it plain and simple I decided to rewrite it to download and execute. Not a big deal as for me, it's still one line. But some users may prefer to review the downloaded script before executing. Please merge the PR and then you may improve it on top the changes once you'll have a time. The changes are better than current from a newcomer user perspective (e.g. like me). |
Please see commit comments for details.