Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable zink #5

Open
wants to merge 8 commits into
base: lineage-20
Choose a base branch
from

Conversation

EliasTheGrandMasterOfMistakes

nvk can be enabled in future for all archs.

problems: lack of fast opengl

how be resolved: zink or angle.

Zink had receive some commits in mesa main to fix android builds, but idk about state
and is necessary to testing, sadly i don't have a nvidia gpu.

Angle: It's fully supported and can works, is necessary to build and use a USE_ANGLE ?= false to disable it as default.
Sadly idk a way to automatic enabling when nvk is used, zink is good because dri2 provides a fallback for zink and load
zink when a Turing or newer gpu is used.

I need opnion about how to figure it.

draft: add a prop for enable nvk in gpus below of Turing+ and force NAK for it

aleasto and others added 7 commits December 3, 2023 15:33
Bug: 220306859
Test: atest
Tag: #feature
Change-Id: I1af8461f8ad82afbb21b43dd6968e824ea89f5d6
Does not exist anymore
Change-Id: I208701b60ddfdd2a15ff17800124c3a693f2990d
@EliasTheGrandMasterOfMistakes EliasTheGrandMasterOfMistakes changed the title DRAFT: enable nvk for x86_64 draft: enable nvk for x86_64 May 3, 2024
@EliasTheGrandMasterOfMistakes EliasTheGrandMasterOfMistakes changed the title draft: enable nvk for x86_64 Draft: enable nvk for x86_64 May 3, 2024
@EliasTheGrandMasterOfMistakes
Copy link
Author

@erfanoabdi @aleasto
sorry for the mention.

What is better? wait next mesa release with fixes for build in zink and try it? i can build a image with this if are necessary using mesa main.

uses angle disabled as default and put in docs to users enable angle when using nvk?

@aleasto
Copy link
Member

aleasto commented May 7, 2024

You don't need to mess with ANGLE at compile time, because in AOSP12+ you can just select ro.hardware.egl=angle in the waydroid prop file

@EliasTheGrandMasterOfMistakes
Copy link
Author

You don't need to mess with ANGLE at compile time, because in AOSP12+ you can just select ro.hardware.egl=angle in the waydroid prop file

oh thank you

@EliasTheGrandMasterOfMistakes EliasTheGrandMasterOfMistakes changed the title Draft: enable nvk for x86_64 enable nvk for x86_64 May 7, 2024
@EliasTheGrandMasterOfMistakes
Copy link
Author

You don't need to mess with ANGLE at compile time, because in AOSP12+ you can just select ro.hardware.egl=angle in the waydroid prop file

it can be integrated like a script?

You don't need to mess with ANGLE at compile time, because in AOSP12+ you can just select ro.hardware.egl=angle in the waydroid prop file

thank you, removed from draft for while

@EliasTheGrandMasterOfMistakes EliasTheGrandMasterOfMistakes changed the title enable nvk for x86_64 enable nvk,zink and gallium va May 10, 2024
@aleasto
Copy link
Member

aleasto commented May 10, 2024

Let's not add random changes here.

VAAPI is tracked in #3

@EliasTheGrandMasterOfMistakes
Copy link
Author

EliasTheGrandMasterOfMistakes commented May 10, 2024

Modified Enable Zink

Future plans for use libcamera.

i don't want to use the same from glodroid but a fork with libcamera softISP v10 with some all necessary patches and simple camera pipeline enabled. idk if this is possible but if is, i can fork libcamera-softisp

i really want to integrate gstreamer too

@EliasTheGrandMasterOfMistakes
Copy link
Author

Let's not add random changes here.

VAAPI is tracked in #3

oh sorry i will remove in this case

@EliasTheGrandMasterOfMistakes
Copy link
Author

Let's not add random changes here.

VAAPI is tracked in #3

removed now

@EliasTheGrandMasterOfMistakes
Copy link
Author

Modified Enable Zink

Future plans for use libcamera.

i don't want to use the same from glodroid but a fork with libcamera softISP v10 with some all necessary patches and simple camera pipeline enabled. idk if this is possible but if is, i can fork libcamera-softisp

i really want to integrate gstreamer too

@aleasto this is required or is possible? project wants to use?
or is better to waiting libcamera softisp be merged and just try to wait glodroid or fork from glodroid with a merge to new version when is launched.

i think in 0.3 will be with initial or 0.4

@EliasTheGrandMasterOfMistakes EliasTheGrandMasterOfMistakes changed the title enable nvk,zink and gallium va enable nvk and zink May 10, 2024
@Quackdoc
Copy link

or is better to waiting libcamera softisp be merged and just try to wait glodroid or fork from glodroid with a merge to new version when is launched.

i think in 0.3 will be with initial or 0.4

if it can be made to work I don't see why not, it may add a little work in the future but having support is something that has been requested for a while now. Upstream would be better, ofc, but it's been a long time anyways so at least we can be used as a testing ground. needs to be a separate PR.

in any case, could always spin up some unofficial builds for people to test

@hmtheboy154
Copy link

Have you make NVK working on Android environment yet ? Or you just got it built ?

@EliasTheGrandMasterOfMistakes
Copy link
Author

Have you make NVK working on Android environment yet ? Or you just got it built ?

sadly i don't have a nvidia card, but is possible to i build a rom and try to find a people in a telegram linux groups that wants to test and have time.

Zink can works in android and looks had necessary extensions.

i need to build it today, to view if works, i will try it after building a rom for motorola rhode. if not builds i will fill a issue in mesa gitlab

@EliasTheGrandMasterOfMistakes
Copy link
Author

or is better to waiting libcamera softisp be merged and just try to wait glodroid or fork from glodroid with a merge to new version when is launched.
i think in 0.3 will be with initial or 0.4

if it can be made to work I don't see why not, it may add a little work in the future but having support is something that has been requested for a while now. Upstream would be better, ofc, but it's been a long time anyways so at least we can be used as a testing ground. needs to be a separate PR.

in any case, could always spin up some unofficial builds for people to test

thank you. i will look at it after this mr.

@EliasTheGrandMasterOfMistakes
Copy link
Author

EliasTheGrandMasterOfMistakes commented May 10, 2024

Have you make NVK working on Android environment yet ? Or you just got it built ?

sadly i don't have a nvidia card, but is possible to i build a images and try to find a people in a telegram linux groups that wants to test and have time.

Zink can works in android and looks had necessary extensions.

i need to build it today, to view if works, i will try it after building a rom for motorola rhode. if not builds i will fill a issue in mesa gitlab

@hmtheboy154
Copy link

sadly i don't have a nvidia card, but is possible to i build a rom and try to find a people in a telegram linux groups that wants to test and have time.

Then only build Zink, leave NVK. Enable it when you sure that it works. NVK is not even a proper Android Vulkan HAL yet.

Signed-off-by: hmtheboy154 <[email protected]>
@EliasTheGrandMasterOfMistakes
Copy link
Author

EliasTheGrandMasterOfMistakes commented May 14, 2024

sadly i don't have a nvidia card, but is possible to i build a rom and try to find a people in a telegram linux groups that wants to test and have time.

Then only build Zink, leave NVK. Enable it when you sure that it works. NVK is not even a proper Android Vulkan HAL yet.

oh thank you
nvk removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants