Add NewHeader constructor function. Remove duplicat functions MakeHea… #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der and buildHeader. Use NewHeader everywhere is possible.
alexeykiselev
added
wip
Add WriteTo and ReadFrom functions to message payloads. Move message payload types to separate file payloads.go. Add Header validation function. Add ChecksumReader that wraps io.Reader and calculates checksum then reading payloads. Functions ParseMessage, ReadMessage and WriteMessage made public. ReadFrom functions of all messages reimplemented using ReadMessage function. Fix linter issues. Unused functions removed.
Fixed read and write of BlockIDsPayload (list of BlockIDs). Added PeersPayload. Fixed writing of messages with empty payloads. U8String moved to payloads.go. Writing of all messages implemented usign function WriteMessage. Unused BulkMessage type removed. Test on mixed BlockIDs in GetBlockIDsMessage added. TestProtocolMarshaling test reimplemented to check all possible ways of serialization/deserialization of messages and fixed to deserialize in empty structures.
alexeykiselev
removed
wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…der and buildHeader.
Use NewHeader everywhere is possible.