New network connection #1547
Merged
New network connection #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests on TaskGroup added.
…ge is used instead.
NetClient usage moved into Universal client. Handshake proto updated to compatibility with Handshake interface from networking package.
Configuration option to set KeepAliveInterval added to networking.Config.
Implement 'io.Stringer' for 'Session' struct. Data race happens because 'clientHandler' mock in 'TestSessionTimeoutOnHandshake' test reads 'Session' structure at the same time as 'clientSession.Close' call.
nickeskov
requested changes
Dec 4, 2024
…t's possible. Replace random delay with constan to make test not blink. Simplify assertion in test to make it stable.
Style fixed.
Added logs on handshake rejection to clarify the reason of rejections. Added and used function to configure Session with list of Slog attributes.
Co-authored-by: Nikolay Eskov <[email protected]>
Proper error declaration.
Shutdown lock replaced with sync.Once.
Co-authored-by: Nikolay Eskov <[email protected]>
Fix data lock and data access order.
nickeskov
reviewed
Dec 16, 2024
nickeskov
reviewed
Dec 16, 2024
nickeskov
reviewed
Dec 16, 2024
nickeskov
reviewed
Dec 16, 2024
Co-authored-by: Nikolay Eskov <[email protected]>
…for client to finish sending handshake. Better wait groups naming.
…unction removed. Handler's OnReceive use io.Reader to pass received data. Tests updated. Mocks regenerated.
nickeskov
reviewed
Dec 28, 2024
nickeskov
previously approved these changes
Dec 28, 2024
irina-pereiaslavskaia
previously approved these changes
Dec 28, 2024
irina-pereiaslavskaia
had a problem deploying
to
ITests
GitHub Actions
Error
alexeykiselev
dismissed stale reviews from irina-pereiaslavskaia and nickeskov
via
de29ff8
nickeskov
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.