Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore what multiple ocean instances would mean #650

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Aug 8, 2020

  1. #540 - explore what multiple ocean instances would mean

    Once i started pulling on the thread i could not stop. This branch should work like
    before iwth one ocean, there are a few issues before it will support multiple instances.
    
    Questions / problems that arose:
    
    Lod data resolution should be global setting, right now taken from one instance
    Validation gets passed "AnyInstance" in a few places, is this ok?
    RenderData.Validate - uses any instance
    RegisterLodDataClipSurface - this sets per-ocean data on MPB. might be tricky to fix..
    How to connect underwater effect to ocean instance?
    How to connect underwater environment lighting with ocean instance?
    Debuggui always takes first instance of ocean, shall we make this selectable?
    OceanChunkRenderer.OnWillRenderObject - tiles will need Layer so it only goes in one camera??
    
    tag @daleeidd @moosichu in case this is of interest
    huwb committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    73c3128 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Configuration menu
    Copy the full SHA
    68b60bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69f441e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Don't serialise camera

    Validation already enforces a camera as a parent.
    daleeidd committed May 14, 2021
    Configuration menu
    Copy the full SHA
    eca9f89 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #829 from wave-harmonic/feature/multiple-oceans-2

    Multiple Oceans: Connect underwater to ocean instance
    daleeidd authored May 14, 2021
    Configuration menu
    Copy the full SHA
    55c79f8 View commit details
    Browse the repository at this point in the history