Bind Ocean Mask Data for ocean chunks not rendered due to occlusion culling #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daleeidd
approved these changes
May 24, 2020
|
Took me a while to get this but I think I get it now - the guard didn't hold up with occlusion culling, because the gameobject/renderer was active? Thumbs up from me, but could we use the underscore naming convention as it's a member variable, or maybe make it a property I guess? |
|
There's a small logical thing that binding is per camera, but we only support one camera properly right now, and it could be expanded to a bool per camera in the future, so I'm happy to go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually set a bool on each ocean chunk that checks if the data is bound, a simpler and more general solution anyway.
Fixes #479, the repro was harder as we were rendering the mask chunks even if culled in the latest release, but this was causing gaps to appear which now seem to be fixed.