Skip to content

Commit

Permalink
Remove ESLint and section from README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
watsonbox committed Oct 1, 2024
1 parent f1bcf01 commit 2a53114
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 305 deletions.
3 changes: 0 additions & 3 deletions .eslintignore

This file was deleted.

23 changes: 0 additions & 23 deletions .eslintrc

This file was deleted.

10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -306,16 +306,6 @@ Run `yarn version`, enter a new version number, then push to build and prepare a
> [!NOTE]
> You may need to run `yarn config set version-tag-prefix ""` before running `yarn version` to ensure the version tag is created correctly.
## Improve code quality with eslint (optional)
- [ESLint](https://eslint.org/) is a tool that analyzes your code to quickly find problems. You can run ESLint against your plugin to find common bugs and ways to improve your code.
- To use eslint with this project, make sure to install eslint from terminal:
- `npm install -g eslint`
- To use eslint to analyze this project use this command:
- `eslint main.ts`
- eslint will then create a report with suggestions for code improvement by file and line number.
- If your source code is in a folder, such as `src`, you can use eslint with this command to analyze all files in that folder:
- `eslint .\src\`

## Resources

- [Strava Developers - Authentication](https://developers.strava.com/docs/authentication/)
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
"@types/luxon": "^3.4.2",
"@types/mustache": "^4.2.5",
"@types/node": "^16.11.6",
"@typescript-eslint/eslint-plugin": "5.29.0",
"@typescript-eslint/parser": "5.29.0",
"builtin-modules": "3.3.0",
"esbuild": "0.17.3",
"jest": "^29.7.0",
Expand Down
2 changes: 0 additions & 2 deletions src/ActivitySerializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import type { Settings } from "./Settings";
// On Unix-like systems / is reserved and <>:"/\|?* as well as non-printable characters \u0000-\u001F on Windows
// credit: https://github.com/sindresorhus/filename-reserved-regex
const REPLACEMENT_CHAR = "-";
// eslint-disable-next-line no-control-regex
const ILLEGAL_CHAR_REGEX_FILE = /[<>:"/\\|?*\u0000-\u001F]/g;
// eslint-disable-next-line no-control-regex
const ILLEGAL_CHAR_REGEX_FOLDER = /[<>:"\\|?*\u0000-\u001F]/g;

export class ActivitySerializer {
Expand Down
Loading

0 comments on commit 2a53114

Please sign in to comment.