Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Allow empty responses #317

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

EstebanDalelR
Copy link
Member

Description

When the commit list is empty, it gave a 500. This is a case of a new repo, we should handle gracefully.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 3:40pm

@watermelon-copilot-for-code-review

WatermelonAI Summary

The commit and the PR in question are about allowing empty responses in a specific case where the commit list is empty. Previously, this would cause a 500 error, but now it is handled gracefully. This is a bug fix and it aligns with the goal of improving user experience by preventing errors in a scenario that can occur with a new repository.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR

Notion Pages

Linear Tickets deactivated by EstebanDalelR
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the mentioned 500 behavior only happening with Slack in the scenario of an empty commit list?

@EstebanDalelR
Copy link
Member Author

Is the mentioned 500 behavior only happening with Slack in the scenario of an empty commit list?

AFAIK, yes, tested a couple times and only slack breaks, so I guess this kills the error.

@EstebanDalelR EstebanDalelR merged commit 3474cb0 into dev Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants