Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Simplify code #60

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Simplify code #60

merged 3 commits into from
Oct 31, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Simplifies the getter to prevent duplication

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

// Adjust the line numbers to be 1-indexed
val adjustedStartLine = startLine + 1
val adjustedEndLine = endLine + 1
blameParameters.add(filePath.path)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanDalelR EstebanDalelR merged commit 07c5b15 into dev Oct 31, 2023
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants