Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Feature/UI improvements #42

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Feature/UI improvements #42

merged 8 commits into from
Sep 27, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Several UI improvements

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Screenshot 2023-09-22 at 12 49 22 PM

Acceptance

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Sep 22, 2023

WatermelonAI Summary

The 8 commits in this Pull Request involve several UI improvements, such as making arrows not bold, changing the appearance of white arrows, compressing the size by not adding an expanded panel, fixing a case when there are no results, and changing the font. The PR also includes the addition of the Roboto Mono font. Overall, these changes aim to enhance the user interface and improve the visual experience of the application.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR

Notion Pages

Linear Tickets

Click here to login to Asana
watermelon-intellij is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The huge spaces that were being programmatically generated between one piece of indexed information and the next one have been removed and that LGTM. But:

  1. The font with serifs doesn't look "computational" the old font was better.

  2. In what we currently have on the dev branch the AI summary (has good quality on our IDE extensions) is expandible. On this branch I'm only able to see the first line.

  3. A minor detail (it can be done later): To improve readibility of the indexed info, the font color of the title of a piece of retrieved info should be different than the one of the body of such.

Attaching an image just in case it's something with my local setup.

Screen Shot 2023-09-22 at 3 44 26 PM

@EstebanDalelR
Copy link
Member Author

The huge spaces that were being programmatically generated between one piece of indexed information and the next one have been removed and that LGTM. But:

1. The font with serifs doesn't look "computational" the old font was better.

2. In what we currently have on the dev branch the AI summary (has good quality on our IDE extensions) is expandible. On this branch I'm only able to see the first line.

3. A minor detail (it can be done later): To improve readibility of the indexed info, the font color of the title of a piece of retrieved info should be different than the one of the body of such.

Attaching an image just in case it's something with my local setup.
Screen Shot 2023-09-22 at 3 44 26 PM
On #2, please show me? I cannot reproduce
Screenshot 2023-09-26 at 10 43 20 AM

@EstebanDalelR
Copy link
Member Author

The huge spaces that were being programmatically generated between one piece of indexed information and the next one have been removed and that LGTM. But:

1. The font with serifs doesn't look "computational" the old font was better.

2. In what we currently have on the dev branch the AI summary (has good quality on our IDE extensions) is expandible. On this branch I'm only able to see the first line.

3. A minor detail (it can be done later): To improve readibility of the indexed info, the font color of the title of a piece of retrieved info should be different than the one of the body of such.

Attaching an image just in case it's something with my local setup.
Screen Shot 2023-09-22 at 3 44 26 PM

On 1., I used Roboto Mono. I chose a mono spaced as it is the most "computational" thing I can imagine, but I can make the background green and letters green. Maybe I can try to get the terminal settings.

@baristaGeek
Copy link
Contributor

The huge spaces that were being programmatically generated between one piece of indexed information and the next one have been removed and that LGTM. But:

1. The font with serifs doesn't look "computational" the old font was better.

2. In what we currently have on the dev branch the AI summary (has good quality on our IDE extensions) is expandible. On this branch I'm only able to see the first line.

3. A minor detail (it can be done later): To improve readibility of the indexed info, the font color of the title of a piece of retrieved info should be different than the one of the body of such.

Attaching an image just in case it's something with my local setup.
Screen Shot 2023-09-22 at 3 44 26 PM

On 1., I used Roboto Mono. I chose a mono spaced as it is the most "computational" thing I can imagine, but I can make the background green and letters green. Maybe I can try to get the terminal settings.

I don't know if it was because of the previously used font family, but the serifs the old font had didn't make it look computational enough. This font looks good now.

@baristaGeek
Copy link
Contributor

The huge spaces that were being programmatically generated between one piece of indexed information and the next one have been removed and that LGTM. But:

1. The font with serifs doesn't look "computational" the old font was better.

2. In what we currently have on the dev branch the AI summary (has good quality on our IDE extensions) is expandible. On this branch I'm only able to see the first line.

3. A minor detail (it can be done later): To improve readibility of the indexed info, the font color of the title of a piece of retrieved info should be different than the one of the body of such.

Attaching an image just in case it's something with my local setup.
Screen Shot 2023-09-22 at 3 44 26 PM
On #2, please show me? I cannot reproduce
Screenshot 2023-09-26 at 10 43 20 AM

I've been trying as well (after pulling the new changes) and haven't been able to as well. Let's just consider it either an edge case or fixed.

@EstebanDalelR EstebanDalelR merged commit 850c0c9 into dev Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants