This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
[BUG] wash claims sign allows empty versions and revisions #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed <[email protected]>
ahmedtadde
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
…wash build` cmd Signed-off-by: Ahmed <[email protected]>
Signed-off-by: Ahmed <[email protected]>
|
Hey @ahmedtadde, as of today, wash has been moved to the wasmCloud repo 🎉 Would you mind re-opening these changes against the main repo? I'm working on switching this repo to be a public archive |
ahmedtadde
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Currently, when signing an actor with
wash, theversion (--ver)andrevision (--rev)args are not required. This will lead to claims that are missing some important information.Related Issues
wasmCloud/wasmCloud#861
Release Information
v0.21.1
Consumer Impact
stricter
wash claims signcmd that ultimately improves the metadata output ofwash inspectTesting
Built on platform(s)
Tested on platform(s)
Acceptance or Integration
updated integration tests integration_claims_sign, integration_claims_call_alias