This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat: add platform and arch bin releasing #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
force-pushed
the
add-platforms-and-archs-bins
branch
9 times, most recently
from
1e080fb
to
68c8c0b
Compare
yordis
commented
Oct 29, 2023
| @@ -55,7 +133,13 @@ jobs: | |||
| id: create_release | |||
| uses: softprops/action-gh-release@v1 | |||
| with: | |||
| files: release/windows/wash.exe | |||
There was a problem hiding this comment.
Is x86_64-pc-windows-gnu binary the same as the one from windows_build?
yordis
commented
Oct 29, 2023
.github/workflows/release.yml
Outdated
| @@ -30,8 +31,8 @@ jobs: | |||
| args: --all-features | |||
|
|
|||
| windows_build: | |||
There was a problem hiding this comment.
is this build needed now?
yordis
force-pushed
the
add-platforms-and-archs-bins
branch
3 times, most recently
from
17c1c37
to
c51773f
Compare
Signed-off-by: Yordis Prieto <[email protected]>
yordis
force-pushed
the
add-platforms-and-archs-bins
branch
from
c51773f
to
a4de2c3
Compare
yordis
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
|
Hey @yordis, as of today, wash has been moved to the wasmCloud repo 🎉 I think the workflow there takes care of building wash for all platforms as well If there are more improvements you want to make, let's open a PR against the main repo. I'm working on updating this repo to be a public archive :) |
|
I love that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.