feat: Adds flake #517
Open
feat: Adds flake #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a nix flake for usage in building things. It is still missing the ability to run an e2e test and build docker images, but it does work for both building and nix shell Signed-off-by: Taylor Thomas <[email protected]>
Signed-off-by: Taylor Thomas <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
|
Special thanks to @rvolosatovs for helping me figure out the cargo.toml munging |
Signed-off-by: Taylor Thomas <[email protected]>
thomastaylor312
force-pushed
the
exp/use_nix
branch
from
6181570 to
772971a
Compare
thomastaylor312
commented
Dec 14, 2024
| serde_json::to_vec(&DeleteModelRequest { | ||
| version: None, | ||
| }).unwrap(), | ||
| serde_json::to_vec(&DeleteModelRequest { version: None }).unwrap(), |
There was a problem hiding this comment.
Note: These changes were just a missing cargo fmt that I found while running tests in the flake
rvolosatovs
approved these changes
Dec 14, 2024
| # Add additional build inputs here | ||
| ] ++ lib.optionals pkgs.stdenv.isDarwin [ | ||
| # Additional darwin specific inputs can be set here | ||
| pkgs.libiconv |
There was a problem hiding this comment.
Is this actually needed in 24.11?
Comment on lines
+243
to
+244
| } // lib.optionalAttrs (!pkgs.stdenv.isDarwin) { | ||
| workspace-llvm-coverage = craneLibLLvmTools.cargoLlvmCov |
There was a problem hiding this comment.
Is this not supported on Darwin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
flake.nixand associated files for a dev environment via nix and steps for building all the parts of wadm in an incremental way. Part of this was an experiment to see what we could get nix to do with monorepo deps in the simple case. Please note that this does not actually add this as part of the build pipeline, just adds the file the repo for people to use. Maybe in the future we can add in builds and caching into our pipelines.