removed aria-label from menu button

washtenawIdtreble · Aug 27, 2023 · cff39a0 · cff39a0
1 parent f6508a5
commit cff39a0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/src/components/navigation/NavMenu-integration.test.tsx b/src/components/navigation/NavMenu-integration.test.tsx
@@ -28,7 +28,7 @@ describe(`${NavMenu.name} (Integration Test)`, () => {
  </MemoryRouter>
  </DocumentStateProvider>
  );
- menuButton = screen.getByRole("button", { name: "Navigation Menu" });
+ menuButton = screen.getByRole("button", { name: "Menu" });
  });
  describe("when the user navigates via the nav menu links", () => {
  let links: HTMLAnchorElement[];

diff --git a/src/components/navigation/NavMenu.test.tsx b/src/components/navigation/NavMenu.test.tsx
@@ -22,7 +22,7 @@ describe(NavMenu.name, () => {
  </MemoryRouter>
  </main>,
  );
- menuButton = screen.getByRole("button", { name: "Navigation Menu" });
+ menuButton = screen.getByRole("button", { name: "Menu" });
  linkList = screen.queryByRole("list");
  });
 

diff --git a/src/components/navigation/NavMenu.tsx b/src/components/navigation/NavMenu.tsx
@@ -83,7 +83,6 @@ export const NavMenu = ({ children }: ChildrenProps) => {
  <button onClick={toggleMenu}
  id={NAV_MENU_BUTTON_ID}
  className={"menu-button"}
- aria-label="Navigation Menu"
  aria-controls={NAV_MENU_ID}
  aria-expanded={isMenuOpen}>
  <MenuIcon/>Menu

diff --git a/src/components/navigation/Navigation.test.tsx b/src/components/navigation/Navigation.test.tsx
@@ -66,7 +66,7 @@ describe(Navigation.name, () => {
  expect(navMenu).toBeInTheDocument();
  });
  test("shows the nav links within the nav menu", async () => {
- await user.click(within(navElement).getByRole("button", { name: "Navigation Menu" }));
+ await user.click(within(navElement).getByRole("button", { name: "Menu" }));
  expect(within(navElement).getAllByRole("link").length).toBeGreaterThan(0);
  });
  describe("and becomes wide", () => {
@@ -85,7 +85,7 @@ describe(Navigation.name, () => {
  });
  describe("and becomes wide with focus on the menu button", () => {
  beforeEach(async () => {
- const navMenuButton = within(navElement).getByRole("button", { name: "Navigation Menu" });
+ const navMenuButton = within(navElement).getByRole("button", { name: "Menu" });
  navMenuButton.focus();
  mocked(window.matchMedia).mockReturnValue({ matches: false } as MediaQueryList);
  await waitFor(() => {
@@ -100,7 +100,7 @@ describe(Navigation.name, () => {
  describe("and becomes wide with focus on a link in the menu", () => {
  let focusedLinkIndex: number;
  beforeEach(async () => {
- await user.click(within(navElement).getByRole("button", { name: "Navigation Menu" }));
+ await user.click(within(navElement).getByRole("button", { name: "Menu" }));
 
  const links = within(navElement).getAllByRole("link");
  focusedLinkIndex = Math.floor(Math.random() * links.length);
@@ -141,7 +141,7 @@ describe(Navigation.name, () => {
  });
  });
  test("the nav menu button appears", () => {
- const navMenuButton = within(navElement).getByRole("button", { name: "Navigation Menu" });
+ const navMenuButton = within(navElement).getByRole("button", { name: "Menu" });
  expect(navMenuButton).toBeInTheDocument();
  });
  });
@@ -157,7 +157,7 @@ describe(Navigation.name, () => {
  });
  });
  test("the nav menu button gains focus", () => {
- const navMenuButton = within(navElement).getByRole("button", { name: "Navigation Menu" });
+ const navMenuButton = within(navElement).getByRole("button", { name: "Menu" });
  expect(navMenuButton).toHaveFocus();
  });
  });