Don't show loading indicator or announce loading if loading finishes …

…before the timeout
washtenawIdtreble · Sep 2, 2023 · abfb5b8 · abfb5b8
1 parent 811f0a5
commit abfb5b8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/pages/Page.test.tsx b/src/pages/Page.test.tsx
@@ -85,7 +85,7 @@ describe(Page.name, () => {
  expect(loadingText).toBeVisible();
  });
 
- test("does not show loading text if loading finished within the timeout period", async () => {
+ test("does not show loading text or indicator if loading finished within the timeout period", async () => {
  const originalAppLoadingTimeout = process.env.REACT_APP_LOADING_TIMEOUT;
  process.env.REACT_APP_LOADING_TIMEOUT = "250";
 
@@ -97,6 +97,9 @@ describe(Page.name, () => {
  const loadingText = within(liveRegion).queryByText("loading");
  expect(loadingText).not.toBeInTheDocument();
 
+ const loadingIndicator = screen.queryByText("Loading...");
+ expect(loadingIndicator).not.toBeInTheDocument();
+
  process.env.REACT_APP_LOADING_TIMEOUT = originalAppLoadingTimeout;
  });
  });
@@ -167,6 +170,7 @@ const ChildComponentThatLoadsData = () => {
  const { startLoading, finishLoading } = useContext(LoadingContext);
 
  return (<>
+ children
  <button onClick={startLoading}>START LOADING</button>
  <button onClick={finishLoading}>STOP LOADING</button>
  </>);