Modification by SG #184

SylvainGa · 2021-01-02T05:52:43Z

Addition of French localization
Addition of Pulse Ox as a data field
Modification to the AlwaysOn to reduce batterie drain

Addition of French localization Addition of Pulse Ox as a data field Modification to the AlwaysOn to reduce batterie drain

warmsound · 2021-01-05T17:55:51Z

@SylvainGa thanks for all your hard work on this 🤝 . I'm starting the review, and will submit comments shortly.

warmsound

Do you have a vector version of the O2 icon? If so, I'd like to update the crystal-icons.afdesign Affinity Designer file after merge. If not, don't worry.

Thanks again for your work on this. If you'd like any help addressing the comments, please let me know.

warmsound · 2021-01-05T18:03:20Z

always-on-source/AlwaysOnDisplay.mc

+		var hours = formattedTime[:hour];
+		var minutes = formattedTime[:min];
+		var amPmText = formattedTime[:amPm];
+		var colon = ":"; // SG Addition


I'm afraid I shouldn't allow the colon and font change to the always-on display: the bold hours/light minutes display is a defining characteristic of Crystal's display, so I'd prefer to keep this as is. The time display should be consistent between regular, and always-on.

For reference, note that this change also affects the newly-supported venusq and venusqm watches, which are currently broken:

The line endings have changed throughout this file.

Would you mind reversing changes to this file, and also to resources-round-390x390/fonts/fonts.xml?

We could consider making this change settings-based in future, although I'm not sure how to resolve the inconsistency with the regular time display, as there's no way a colon would fit for some devices.

Sorry, I've just noticed that the reason for making the always-on changes was to reduce battery drain. Is the saving due to using fewer fonts?

Yes, the bold characters for the hours has many more 'on' pixels than the ':' between the hours and minutes. Nevertheless, my watch went from 1% per hour tp 4-5% per hour with always on so I turned it off. I didn't want my watch to turn to an Apple watch requiring a daily charge lol.

I've checked all the 'AlwaysOnHoursFont' and made sure the ':' is present.

warmsound · 2021-01-05T18:09:40Z

resources-fre/strings/strings.xml

+	<string id="ThemeBlueDark">Bleu (sur fond noir)</string>
+	<string id="ThemePinkDark">Rose (sur fond noir)</string>
+	<string id="ThemeRedDark">Rouge (sur fond noir)</string>
+	<string id="ThemeGreenDark">Vert(sur fond noir)</string>


Missing space:

Suggested change

<string id="ThemeGreenDark">Vert(sur fond noir)</string>

<string id="ThemeGreenDark">Vert (sur fond noir)</string>

warmsound · 2021-01-05T18:10:31Z

resources-fre/strings/strings.xml

 	<string id="Mar">Mar</string>
 	<string id="Apr">Avr</string>
 	<string id="May">Mai</string>
 	<string id="Jun">Juin</string>
 	<string id="Jul">Juil</string>
-	<string id="Aug">Aout</string>
+	<string id="Aug">Août</string>


Many thanks for all these translations.

The accented û is not included in one or more date fonts, so appears incorrectly. Could you fix this?

Do you know which font is used or do simply cut and paste a standard 'u' and add a caret over it in PaintShopPro to make a û?

I think I've catched them all. Also fixed the ':' for low power mode Venu Sq.

warmsound · 2021-01-05T18:11:51Z

resources/strings/strings.bak

@@ -0,0 +1,104 @@
+<strings>


Please remove this file, as I think it's not longer needed.

Ok, no problem

warmsound · 2021-01-05T18:11:59Z

source/DataFields.bak

@@ -0,0 +1,730 @@
+using Toybox.WatchUi as Ui;


Please remove this file, as I think it's not longer needed.

warmsound · 2021-01-05T18:19:13Z

resources/settings/settings.xml

@@ -88,6 +88,7 @@
 			<listEntry value="10">@Strings.SunriseSunset</listEntry>
 			<listEntry value="11">@Strings.Weather</listEntry>
 			<listEntry value="13">@Strings.Humidity</listEntry>
+			<listEntry value="14">@Strings.PulseOx</listEntry>


Crystal should only show settings that are actually supported by a given device (see how e.g. Temperature and Floors are handled). currentOxygenSaturation is only supported by quite a limited set of devices - is there an easy way we can hide the setting from other devices?

Do you mean like for example the resource file resources-approachs62 has "listEntry value="1">@Strings.FloorsClimbed</listEntry" in comments? If so, would that mean a specific resource file for each device that supports Pulse Ox?

Because it's supported by quite a few devices now:

Captain Marvel
D2™ Air
Darth Vader™
Descent™ Mk2 / Descent™ Mk2i
Descent™ Mk2 S
Enduro™
First Avenger
Forerunner® 245
Forerunner® 245 Music
Forerunner® 745
Forerunner® 945
Forerunner® 945 LTE
fēnix® 5X Plus
fēnix® 6 / 6 Solar / 6 Dual Power
fēnix® 6 Pro / 6 Sapphire / 6 Pro Solar / 6 Pro Dual Power / quatix® 6
fēnix® 6S / 6S Solar / 6S Dual Power
fēnix® 6S Pro / 6S Sapphire / 6S Pro Solar / 6S Pro Dual Power
fēnix® 6X Pro / 6X Sapphire / 6X Pro Solar / tactix® Delta Sapphire / Delta Solar / Delta Solar - Ballistics Edition / quatix® 6X / 6X Solar / 6X Dual Power
MARQ™ Adventurer
MARQ™ Athlete
MARQ™ Aviator
MARQ® Captain / MARQ® Captain: American Magic Edition
MARQ™ Commander
MARQ™ Driver
MARQ™ Expedition
MARQ™ Golfer
Rey™
Venu™
Venu™ 2
Venu™ 2S

warmsound · 2021-01-05T18:22:10Z

resources/strings/strings.xml

@@ -76,6 +76,7 @@
 	<string id="Weather">Weather</string>
 	<string id="Humidity">Humidity</string>
 	<string id="Pressure">Pressure</string>
+	<string id="PulseOx">Pulse Ox</string>


Please also add this string to the remaining 19 translation files, so that it can be easily translated in future.

warmsound · 2021-01-05T18:23:21Z

source/DataFields.mc

+				activityInfo = Activity.getActivityInfo();
+				sample = activityInfo != null and activityInfo has :currentOxygenSaturation ? activityInfo.currentOxygenSaturation : null;
+				if (sample != null) {
+					value = sample.format(INTEGER_FORMAT);


Do you think the PulseOx value should be shown with a trailing "%", like Humidity and Battery?

Would make sense, yes since it's a percentage

SylvainGa · 2021-01-05T19:01:36Z

Do you have a vector version of the O2 icon? If so, I'd like to update the crystal-icons.afdesign Affinity Designer file after merge. If not, don't worry.

Thanks again for your work on this. If you'd like any help addressing the comments, please let me know.

No, I'm sorry. I don't have a vectored graphic for the O2. I simply used PaintShop Pro and used the font Segoe UI to write O and 2 using two different font size.

warmsound · 2021-01-24T11:03:23Z

@SylvainGa, would you like any help with this? I'd be happy to merge as is, and then I could make further changes before release, along the above lines. Your changes are valuable, so it'd be great to get them in 👍

SylvainGa · 2021-01-25T21:28:05Z

Sorry, had a ski accident. I went through what was posted and see what I can do this week,

warmsound · 2021-01-28T17:46:58Z

Sorry to hear about your accident. Wishing you a speedy recovery, and thank you again for your work on this - there's no urgent hurry.

lrosenman · 2021-06-10T02:46:42Z

I would love to see this make it into a release at some point.

SylvainGa · 2021-09-17T15:13:10Z

I've started working on it again. Refreshed my laptop so had to refork and redo my changes (kept my source). See my question in your post about Pulse Ox

#184 (comment)

SylvainGa · 2022-03-23T00:00:34Z

Hi Larry, hope you're doing well. I haven't seen any movement for almost a year in your crystal-face Garmin watchface. Are you still planning on releasing a new version with the updated code? Regards, Sylvain. Le mer. 9 juin 2021, à 22 h 46, Larry Rosenman ***@***.***> a écrit :

…

I would love to see this make it into a release at some point. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#184 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALYXESRJVSDBYQAK5ZTW5LLTSARR7ANCNFSM4VQ2A26Q> .

lrosenman · 2022-03-23T00:07:26Z

I'm not the code owner.

@warmsound is.

SylvainGa · 2022-03-23T12:48:57Z

Hi, I hope you're doing well. I haven't seen any movement for almost a year in your crystal-face Garmin watchface. Are you still planning on releasing a new version with the updated code? Regards, Sylvain. Le jeu. 28 janv. 2021, à 12 h 47, warmsound ***@***.***> a écrit :

…

Sorry to hear about your accident. Wishing you a speedy recovery, and thank you again for your work on this - there's no urgent hurry. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#184 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALYXEST5BGCL7EMAQHAXAGDS4GPKHANCNFSM4VQ2A26Q> .

SylvainGa · 2022-03-23T12:49:25Z

Yeah, sorry. Replied to the wrong thread. Le mar. 22 mars 2022, à 20 h 07, Larry Rosenman ***@***.***> a écrit :

…

I'm not the code owner. @warmsound <https://github.com/warmsound> is. — Reply to this email directly, view it on GitHub <#184 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALYXESW23TW25DED4YHUYYDVBJOETANCNFSM4VQ2A26Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Modification by SG

b7b4127

Addition of French localization Addition of Pulse Ox as a data field Modification to the AlwaysOn to reduce batterie drain

warmsound self-assigned this Jan 4, 2021

warmsound requested changes Jan 5, 2021

View reviewed changes

warmsound modified the milestones: 2.4.5, 2.4.6 Jan 12, 2021

warmsound removed this from the 2.4.6 milestone Apr 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modification by SG #184

Modification by SG #184

SylvainGa commented Jan 2, 2021

warmsound commented Jan 5, 2021

warmsound left a comment •

edited

Loading

warmsound Jan 5, 2021

warmsound Jan 5, 2021

SylvainGa Jan 5, 2021

SylvainGa Sep 17, 2021

warmsound Jan 5, 2021

warmsound Jan 5, 2021

SylvainGa Jan 26, 2021

SylvainGa Sep 17, 2021

warmsound Jan 5, 2021

SylvainGa Jan 26, 2021

warmsound Jan 5, 2021

warmsound Jan 5, 2021

SylvainGa Jan 26, 2021

SylvainGa Sep 17, 2021

SylvainGa Sep 17, 2021

warmsound Jan 5, 2021

SylvainGa Sep 17, 2021

warmsound Jan 5, 2021

SylvainGa Jan 26, 2021

SylvainGa Sep 17, 2021

SylvainGa commented Jan 5, 2021

warmsound commented Jan 24, 2021

SylvainGa commented Jan 25, 2021 via email •

edited

Loading

warmsound commented Jan 28, 2021

lrosenman commented Jun 10, 2021

SylvainGa commented Sep 17, 2021

SylvainGa commented Mar 23, 2022 via email

lrosenman commented Mar 23, 2022

SylvainGa commented Mar 23, 2022 via email

SylvainGa commented Mar 23, 2022 via email

	<string id="ThemeGreenDark">Vert(sur fond noir)</string>
	<string id="ThemeGreenDark">Vert (sur fond noir)</string>

Modification by SG #184

Are you sure you want to change the base?

Modification by SG #184

Conversation

SylvainGa commented Jan 2, 2021

warmsound commented Jan 5, 2021

warmsound left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SylvainGa commented Jan 5, 2021

warmsound commented Jan 24, 2021

SylvainGa commented Jan 25, 2021 via email • edited Loading

warmsound commented Jan 28, 2021

lrosenman commented Jun 10, 2021

SylvainGa commented Sep 17, 2021

SylvainGa commented Mar 23, 2022 via email

lrosenman commented Mar 23, 2022

SylvainGa commented Mar 23, 2022 via email

SylvainGa commented Mar 23, 2022 via email

warmsound left a comment •

edited

Loading

SylvainGa commented Jan 25, 2021 via email •

edited

Loading