feat(syswall): Adding syswall capability to wazero #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ritesh089 and thanks for another PR! waPC was created before WASI really existed. I'm thinking access to time and rand are benign and should instead be allowed by default. Things like FS access is more sensitive and would need special (but that is beside the point). Why not use this for the wazero config and remove the wazero-specific setting in WithRandSource(rand.Reader).
WithSysNanosleep().
WithSysNanotime().
WithSysWalltime() |
ritesh089
force-pushed
the
feature/syswall
branch
from
73e8df7
to
e8f054d
Compare
ritesh089
force-pushed
the
feature/syswall
branch
from
e8f054d
to
e6a4fe0
Compare
|
I agree . Updated the PR . Please let me know if I need to make any additional changes on this. |
|
@ritesh089 released your recent PRs as v0.6.2. Enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when users use the time package in wapc, an incorrect timestamp is returned.
This PR provides the option to use Syswall.