-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake #454
Cmake #454
Conversation
still missing: 1. branching for serial/parallel testing 2. config setup for compiler options 3. integration to github runner 4. documentation
…nt variables (i.e. to use them)
e79f5d2
to
6ea99f4
Compare
50646b2
to
c289a67
Compare
@JeromeCCP9 I have rebased your commits to the current |
- `flang-new` does not appear to be fully implemented in 16.0.6 Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Note: |
@LecrisUT This is great! wannier_lib.F90 is obsolete now and I'll remove it, and I'll fix the test failures. I'll go through this now and reply again... |
Indeed, but I think for this PR, we just make the basic cmake builder and CI so that there is a base framework to work with. It would not be production ready, but then when There are a few other minor issues that should be addressed, but let's focus on this PR to get the github action running, then I can address some of them. E.g. besides this PR, I think we also need #444 to properly test the packaging, such as the usage of |
@JeromeCCP9 I want to squash and redo this PR keeping the makefile build for now. Are you ok with losing your commit authorship for this? |
Hi! I guess you discussed with Giovanni P at the ESL meeting? When we talked last week, along with some other folks, we decided indeed to keep the usual makefile and setup cmake in parallel (despite this being a bit messy). What would you like to do? My plan was to close this PR and setup a new one adding (a slimmed down) CMakeLists setup to that. |
Yes, basically I want to:
|
That sounds great to me! In which case I will not touch the cmake etc for a while unless you mention me here or so (you can also email me if I am slow etc). |
Expect PRs in a few min ;) |
Superseeded by #487 |
I have rebased the branch in #440 to point to the current
develop
head. Also reconfigured the GitHub workflows to run through ctest. Many things were deleted from the old workflow as I copied the workflow from other projects. If there is something missing that should be there, let me know.Also there are a few improvements from the last cmake PR: