Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lonely_job to use new locking pattern #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joetastic
Copy link

This takes uses the new suggestion as specified at http://redis.io/commands/set

@wallace
Copy link
Owner

wallace commented Jan 5, 2014

Sorry for the all the comment spam. I've researched the resque-lonely_job incompatibility with resque 1.25.x and it was due to the strict dependency on mock_redis.

I've released 1.0.1, the current HEAD of master and you'll want to rebase off of that. :)

If you can keep lock_timeout as part of the public API, that'd be great and I'd be happy to merge that in and release a 2.0.0 version of resque-lonely_job that changes its depedency to resque 1.21, which is when resque loosened its dependency on redis-namspace to 1.x which adds support for redis-rb 3.0.x. And redis-rb 3.0.5 is when support for Redis 2.6.12+ is added with SET and its arguments like NX.

Cheers!

@pboling pboling self-assigned this Mar 21, 2021
@pboling
Copy link
Collaborator

pboling commented Mar 21, 2021

@joetastic This looks like a great idea.

The supported fork of this project is resque-unique_at_runtime. I am the maintainer of both, and I will be releasing a new version of this gem with an upgrade path toward resque-unique_at_runtime.

I will look into adding this to resque-unique_at_runtime

Ref: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants