Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed OG data #70

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Changed OG data #70

merged 1 commit into from
Nov 3, 2024

Conversation

nicosomb
Copy link
Member

@nicosomb nicosomb commented Nov 2, 2024

Should fix #69

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for wallabag-website ready!

Name Link
🔨 Latest commit e3422c3
🔍 Latest deploy log https://app.netlify.com/sites/wallabag-website/deploys/67274e39647e3d0008b52b70
😎 Deploy Preview https://deploy-preview-70--wallabag-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicosomb
Copy link
Member Author

nicosomb commented Nov 2, 2024

@HolgerAusB
Copy link

  • og:title is good now
  • date is in wrong format and is not parsable by wallabag. I am not a developer, but try {{ page.date.toISOString }} which should result in something like: 2024-11-01T09:00:00.000Z
  • for 'description' without 'og:' i might messing up things. I don't know, if this should contain the site.description or the page excerpt, sorry. But...
  • og:description line is now missing completely in the template, this should contain an excerpt of current page. I assume 11ty is not auto-generating an excerpt. So you either need to have a handwritten short-line in your pages head or using a plugin which is just shorten the body. We don't need this for wallabag fetch but it could beautifying the preview cards in social media.
---
title: the title
date: 2024-11-01
desciption: Short excerpt of the body text here
---

@nicosomb
Copy link
Member Author

nicosomb commented Nov 3, 2024

@HolgerAusB it should be better with my latest changes ;-)

@HolgerAusB
Copy link

@nicosomb. The date is now different but still not in the correct format (in my opinion, which might be wrong). But now it is parseable by wallabag, so I am fine with it. Thank you.

@nicosomb
Copy link
Member Author

nicosomb commented Nov 3, 2024

What is the correct format?

@HolgerAusB
Copy link

as far as I found on most sources when writing site configs, it should be more like this:
2024-11-01T09:00:00.000Z. But as I said, maybe I am wrong

And google said, that should be working with this in your _head template:
{{ page.date.toISOString }}

@nicosomb nicosomb merged commit 1e059f9 into main Nov 3, 2024
7 checks passed
@nicosomb nicosomb deleted the change-og branch November 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please fix og:title and add date field
2 participants