Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass hashed URL to Wallabag when testing for entry existence, rather than cleartext URL #370

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

00dani
Copy link
Contributor

@00dani 00dani commented Oct 2, 2023

This addresses issue #204, which I opened myself quite some time ago. The general implementation is fairly simple, but because Wallabagger officially supports Edge > 14 there were some polyfills required for compatibility - if we're happy to only support the Chromium-based versions of Edge first introduced in 2019 with Edge 79, then all of these polyfills can be safely removed.

The Wallabag server version is taken into account, and Wallabagger will automatically fall back to using cleartext URLs if it's talking to an older server that doesn't support hashed_url. Most should at this point, though, since 2.4.0 was released almost three years ago (!!).

@lsferreira42
Copy link

Hello,

How can i help this pull request? It's a very wanted feature as i use a shared wallabag instance with some friends and this is a privacy concern!

@00dani
Copy link
Contributor Author

00dani commented Mar 20, 2024

@lsferreira42 Well, the PR ought to be ready to merge, now that I've fixed up that conflict in package-lock.json. Depending on our targeted browsers, it might make sense to remove the polyfills I included for cryptography, but they're not gonna actually hurt anything if they are included.

The problem is that it looks like Wallabagger isn't very actively maintained, since I put this up back in October and it doesn't seem like any maintainers have looked at it since then. 🤔

@Simounet
Copy link
Member

I'm really sorry for this delay. I'll look into it this week.

@lsferreira42
Copy link

Thank you @Simounet !!

@Simounet Simounet force-pushed the feature/support-hashed-url branch from 020f25b to 45aa7c8 Compare March 20, 2024 20:27
@Simounet Simounet force-pushed the feature/support-hashed-url branch from 45aa7c8 to da0d49a Compare March 20, 2024 21:14
@Simounet Simounet merged commit b571c4b into wallabag:master Mar 20, 2024
1 check passed
@Simounet
Copy link
Member

Thank you so much @00dani for this feature! And I'm really sorry for the delay… I'll push it into a new release ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants