Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable subfolder paths with placeholder support #300

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cegekaJG
Copy link

This PR adds the property "FolderPathPattern" to the extension's settings and expands the functionality of the "Reorganize" function.
The new property allows users to define a custom subfolder path using the same placeholders used for object and file names. It also adds some new placeholders such as <AlSubFolder> to ensure the default value retains the same behavior as before.
Finally, it reorganizes the pattern matching code to remove some duplicate code by reusing functions.

This PR addresses #297.

@waldo1001
Copy link
Owner

I just noticed this, sorry.
First - thanks so much for taking the time!
Second - it's one of the biggest PRs I ever got - and since I'm totally not using the "reorganize" feature myself, I'm not sure about this.

How do you see the impact? Do we risk breaking changes?

@cegekaJG
Copy link
Author

It's been a while, but I've tested a few scenarios, especially to ensure the new settings wouldn't break old configurations. Behavior will only deviate when using the new template property, and I am reusing the same S/R logic as the one for the filenames, so it should be stable. There is one new placeholder that can also be used for filenames, so technically it is possible to introduce a breaking change if a repository is using the exact string of the new placeholder explicitly, but that's very unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants