feat: check filter against lightPush, basic implementation #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weboko
commented
Oct 15, 2024
| @@ -56,6 +56,6 @@ export function messageHashStr( | |||
| message: IProtoMessage | IDecodedMessage | |||
| ): string { | |||
| const hash = messageHash(pubsubTopic, message); | |||
| const hashStr = bytesToUtf8(hash); | |||
| const hashStr = bytesToHex(hash); | |||
There was a problem hiding this comment.
this is fix for messageHashStr when it doesn't transform bytes properly and shows weird symbols
|
This is temporary approach and should be revisited in #2075 |
size-limit report 📦
|
adklempner
reviewed
Oct 16, 2024
adklempner
approved these changes
Oct 16, 2024
danisharora099
approved these changes
Oct 16, 2024
I suppose there was an outage and wrong versions / configs were used lol |
weboko
added a commit
that referenced
this pull request
Oct 16, 2024
* feat: lighten retry logic for LightPush * update tests * remove base protocol sdk from light push, add unit tests for light push * remove replaced test * ensure numPeersToUse is respected * turn off check for missing messages * fix recurring ping * add useful logs * skip tests * remove comment * feat: check filter subscriptions against lightPush (#2185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We observe some full nodes in the network that accept
subscriptionrequest fromjs-wakubut do not push messages later.Solution
As mitigation for it implement basic handler for sending ephemeral message during subscription setup and check.
Notes