feat(tests): several enrtree + static multiaddr for bootstrap #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danisharora099
changed the title
5 tasks
size-limit report 📦
|
weboko
reviewed
Aug 7, 2023
fryorcraken
reviewed
Aug 8, 2023
| bootstrap({ list: [multiAddrWithId.toString()] }), | ||
| wakuDnsDiscovery( | ||
| [enrTree["PROD"], enrTree["TEST"]], | ||
| NODE_REQUIREMENTS |
There was a problem hiding this comment.
Can we make this value optional if not already?
There was a problem hiding this comment.
good idea - addressed here: #1466
danisharora099
commented
Aug 9, 2023
| @@ -70,7 +70,6 @@ | |||
| "@types/dockerode": "^3.3.17", | |||
| "@types/mocha": "^10.0.1", | |||
| "@types/tail": "^2.2.1", | |||
| "@waku/sdk": "*", | |||
There was a problem hiding this comment.
@waku/sdk was being init twice in devDependencies for some reason and wasn't throwing an error 👀
There was a problem hiding this comment.
I think it even shouldn't as the last overrides former from JS point of view, but it's interesting how it got there
danisharora099
changed the title
fryorcraken
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test, and to showcase, the usage of multiple ENR trees and also the ability to add specific multiaddrs along with it.