Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update guide for v0.027 #221

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

danisharora099
Copy link
Contributor

@danisharora099 danisharora099 commented Sep 30, 2024

Updates NetworkConfig related breaking-API for #193

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-waku-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:31am

shardInfo: shardInfo,
networkConfig: {
clusterId: 1,
contentTopics: ["/my-app/1/notifications/proto"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make it clearer that this should be the preferred method? Maybe put it first, and put static sharding config in in its won section with a title "alternative network config"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good: 430e395

@danisharora099 danisharora099 merged commit 51703d1 into shard-info-js-waku Oct 1, 2024
2 of 3 checks passed
@danisharora099 danisharora099 deleted the chore/update-network-config branch October 1, 2024 06:31
@danisharora099 danisharora099 restored the chore/update-network-config branch October 1, 2024 06:32
@danisharora099 danisharora099 deleted the chore/update-network-config branch October 1, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants