aws crt client #64
Draft
aws crt client #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I have been evaluating the AWS CRT Client in a different repo: https://github.com/sullis/s3-playground/tree/main/src/test/java/io/github/sullis/s3/playground The |
wakingrufus
reviewed
Oct 11, 2024
| .maxConcurrency(clientConfig.maxConcurrency) | ||
| clientConfig.readWriteTimeout?.also { | ||
| builder.readTimeout(it).writeTimeout(it) | ||
| // TODO fixme |
There was a problem hiding this comment.
does the CRT client just not have this feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Draft PR.
The purpose of this PR is to evaluate Amazon's CRT client
CRT client availability
The AWS CRT client was announced in February 2023
https://aws.amazon.com/blogs/developer/announcing-availability-of-the-aws-crt-http-client-in-the-aws-sdk-for-java-2-x/
Reference
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/http-configuration.html
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/http-configuration-crt.html
Amazon's flowchart
According to Amazon's flowchart, the CRT client is preferred for most applications.