Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to js file #117

Merged
merged 1 commit into from
Mar 16, 2024
Merged

move to js file #117

merged 1 commit into from
Mar 16, 2024

Conversation

VictoriqueMoe
Copy link
Member

toLocaleString returns a localised formatted string of a number. doing this on the server means that it will always be formatted to EN-GB and never to the local browser. so this should be moved to the browser

Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@VictoriqueMoe VictoriqueMoe merged commit 0fde9fd into main Mar 16, 2024
1 check passed
@VictoriqueMoe VictoriqueMoe deleted the move-local-string branch March 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants