Refact/project setting #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: prod 배포에 git flow 적용 feat: dev 수동 배포 추가
fivessun5
approved these changes
Sep 25, 2023
shp7724
reviewed
Sep 25, 2023
waffledotcom/src/secrets.py
Outdated
| ) | ||
| cache_config = SecretCacheConfig() | ||
| self.cache = SecretCache(config=cache_config, client=client) | ||
| self.secret_name = f"{settings.env}/wacruit" |
There was a problem hiding this comment.
오 실수했네요 감사감사 ce70c6a
shp7724
reviewed
Sep 25, 2023
.github/workflows/deploy-prod.yaml
Outdated
Comment on lines
5
to
6
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
develop/main 브랜치랑 tag-based deployment 어떻게 병행하면 되는지 리드미에 간략히 적어주면 좋을듯요
There was a problem hiding this comment.
P1: 그리고 이제부터 PN룰 지켜주셈!!
There was a problem hiding this comment.
태그 배포는 master에만 적용하고
develop 브랜치는 그냥 머지하는 족족 자동배포되는거죠?
There was a problem hiding this comment.
얍얍 맞습니다
그리고 deploy-dev-manual.yaml 파일을 추가했는데, 이걸로 develop 브랜치가 아니라 내가 개발 중인 피처 브랜치를 임시로 develop 대신에 수동 배포할 수 있음
이걸 넣은 이유는 로컬에서만 테스트하고 막상 develop에 머지하면 뭔가 제대로 잘 작동하지 않는 경우가 많았던 것 같아서, develop 머지 전에 피처 브랜치를 클러스터에 올려서 e2e 테스트를 해볼 수 있도록 한 거임
근데 물론 이건 3명이 동시에 사용하면 문제가 될 수 있으니 슬랙에서 잘 공유하고 사용해야 됨
shp7724
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아래와 같이 프로젝트 세팅을 수정했습니다.