fix: slack profile github validation 개선

wafflestudio · Jul 5, 2024 · 5a23540 · 5a23540
1 parent 95b996c
commit 5a23540
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/waffledotcom/src/batch/slack/schema.py b/waffledotcom/src/batch/slack/schema.py
@@ -44,9 +44,14 @@ def check_phone_number(cls, value: str | None) -> str | None:
     @classmethod
     def check_github_id(cls, value: str | None) -> str | None:
         result = urlparse(value)
-        assert result.scheme == "https", "Invalid URL scheme"
-        assert result.netloc in ["github.com", "www.github.com"], "Invalid URL netloc"
-        return str(result.path).split("/")[1]
+        if result.scheme != "https":
+            return None
+        if not isinstance(result.netloc, str):
+            return None
+        if result.netloc.endswith("github.com"):
+            return str(result.path).split("/")[1]
+        if result.netloc.endswith("github.io"):
+            return str(result.netloc).split(".")[0]
 
 
 class SlackMember(BaseModel):