Fix handling not found record case

wadahiro · Mar 1, 2018 · d61e2f5 · d61e2f5
1 parent 9ee9408
commit d61e2f5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/amazondns.go b/amazondns.go
@@ -105,27 +105,27 @@ L:
 }
 
 func handleNotFound(zone *Zone, name string, m *dns.Msg) {
+	// Set authority
 	m.Ns = []dns.RR{zone.soa}
 
-	if name == zone.soa.Header().Name {
-		m.Rcode = dns.RcodeSuccess
-		return
-	}
-	for _, ns := range zone.ns {
-		if name == ns.Header().Name {
+	if m.Rcode == dns.RcodeNameError {
+		if name == zone.soa.Header().Name {
 			m.Rcode = dns.RcodeSuccess
 			return
 		}
-	}
-	for _, nsa := range zone.nsa {
-		if name == nsa.Header().Name {
-			m.Rcode = dns.RcodeSuccess
-			return
+		for _, ns := range zone.ns {
+			if name == ns.Header().Name {
+				m.Rcode = dns.RcodeSuccess
+				return
+			}
+		}
+		for _, nsa := range zone.nsa {
+			if name == nsa.Header().Name {
+				m.Rcode = dns.RcodeSuccess
+				return
+			}
 		}
 	}
-
-	// Error
-	m.Rcode = dns.RcodeNameError
 }
 
 func resolveCNAME(reqName string, res *dns.Msg) {

diff --git a/build.sh b/build.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-VERSION=0.2
+VERSION=0.2.1
 TAG=b1ce9ed6e5b6178fbfa73d3764d25a6e1f20fc82
 CADDY_TAG=37b291f82c2083a378b698577640389686b0baf4
 
@@ -44,7 +44,7 @@ else
     go build
 
     cp coredns /go/src/github.com/wadahiro/coredns-amazondns/
-    tar cvzf coredns-amazondns-$VERSION.tar.gz coredns
-    mv coredns-*.tar.gz /go/src/github.com/wadahiro/coredns-amazondns/
+    tar cvzf coredns-amazondns_${VERSION}_linux-amd64.tgz coredns
+    mv coredns-*.tgz /go/src/github.com/wadahiro/coredns-amazondns/
 fi