Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Chain - Milestone 1 #966

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Tracking Chain - Milestone 1 #966

merged 4 commits into from
Aug 10, 2023

Conversation

FedeC87p
Copy link
Contributor

@FedeC87p FedeC87p commented Aug 8, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1847

@Whisker17
Copy link
Contributor

Hey @FedeC87p, I've finished my evaluation here #969. Everything goes fine for me, just a small problem: I can't open Swagger UI. Could you have a look on that, appreciate it!

@FedeC87p
Copy link
Contributor Author

FedeC87p commented Aug 9, 2023

Thanks for the review @Whisker17 Could you give me some details about the error? Because it's working for me, Swagger is configured on the Triage API service (not WebApplication), which at least in the case of my examples is on port 5000. The generated json is located at http://localhost:5000/swagger/v1 /swagger.json (web interface at http://localhost:5000/swagger)

@Whisker17
Copy link
Contributor

Hey @FedeC87p, I just had a test again, seems everything goes fine with me(including the Swagger UI). So I would accept this milestone, appreciate your work!

@dsm-w3f dsm-w3f self-assigned this Aug 9, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 10, 2023

@FedeC87p thank you for the milestone delivery and @Whisker17 thanks for the external evaluation. I was able to check the the application. However, in the Ink! smart contract there is a problems to compile it. I needed to add the code below to the Cargo.toml to be able to compile it.

[lib]
path = "lib.rs"
crate-type = ["cdylib"]

This problem don't that prevents the approval of the milestone but would be nice to fix it. The milestone is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 619d94d into w3f:master Aug 10, 2023
6 checks passed
@FedeC87p
Copy link
Contributor Author

Thank you for the review, I will immediately rectify the Smart Contact so that I can begin developing Milestone 2.

@RouvenP
Copy link

RouvenP commented Aug 28, 2023

hi @FedeC87p we transferred the payment today - apologies for the delay

@FedeC87p
Copy link
Contributor Author

No problem, thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants