AssetHub: Atomic Swap NFT indexer M1

[vikiival]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2271 < please fill this in with the PR number of your application.

[keeganquigley]

Hi @vikiival thanks for the delivery.

• The license file is broken. Can you please fix it to point to https://github.com/kodadot/stick/blob/main/LICENSE
• Are there unit tests for the CRUD handler as well?

[vikiival]

• The license file is broken. Can you please fix it to point to

Fixed in 9a9ef8d

• Are there unit tests for the CRUD handler as well?

Unit tests that require usage database are very tricky to write.
We have written unit tests to ensure that data transformation pipeline is returning expected data.

Regarding to the testing @subsquid team has promised some kind of testing framework for internals.

[keeganquigley]

Thanks for the changes @vikiival much appreciated. Moving forward, there are still some TODO comments in this file. Since this is the last milestone, are you able to address these now?

[keeganquigley]

Regarding to the testing https://github.com/subsquid team has promised some kind of testing framework for internals.

Additionally, regarding the above, did you get a response?

[vikiival]

did you get a response?

[vikiival]

TODO comments in this file.

• added clarification for dev - kodadot/stick@6fefe71
• implemented saving if its present in schema - kodadot/stick@f1bbe87

[vikiival]

gm @keeganquigley any progress>

[keeganquigley]

Thanks for the fixes @vikiival and sorry for the delay, as I was out of office last week. The TODOs have been fixed, and I'm assuming it will take some time for Subsquid to flesh out the internal testing framework (regarding the above). Since the application deliverables don't specify anything about testing for downstream dependencies, I'm willing to go ahead and pass it, but consider adding additional coverage.

Thanks and here is my final evaluation.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[vikiival]

sorry for the delay

No problem, I'd rather asked ^-^

as I was out of office last week.

Sun is shining ☀️, you are making awesome job. Your OOO was well-deserved!

[vikiival]

Form submitted.
Wish you a pleasant summer 🥹💚

[RouvenP]

hi @vikiival we just transferred the DOTs