Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Security and Privacy Considerations #1360

Closed

Conversation

mmccool
Copy link
Contributor

@mmccool mmccool commented Jan 24, 2022

@sebastiankb
Copy link
Contributor

please also consider #1363

@mmccool
Copy link
Contributor Author

mmccool commented Feb 2, 2022

Updated to implement split into two sections, security and privacy considerations. Note: the id's still all contain "sec-security-considerations". I'll probably update the ids as well but only after I check that there I won't break any links (at least within the document...).

@j1y3p4rk
Copy link

j1y3p4rk commented Feb 7, 2022

I reviewed it, and the privacy part is well written.

In the security consideration part, I have minor change requests.

In 9.1 TD Interception and Tempering Security Risk- mitigation part, "mutual authenticated channels" --> "mutual authenticated secure channels" because actually mutual authentication does not help to mitigate MITM attack but secure (encrpyted) channel established after mutual authentication does.

With the same reason, I would like to ask to change in the chapter 9.2 Context Interception and Tempering Security Risk - Mitigation part, "obtained through authenticated channels" --> "obtained through secure channels established by mutual authenication" something like that..

If discussion is needed, we can do that in the security call.

@mmccool
Copy link
Contributor Author

mmccool commented Feb 7, 2022

  • Probably need a generic security consideration around mitigating all OWASP Top 10 security issues (see also Discovery). Maybe not a consideration, but a reference in the intro in the same place we reference the WoT Best Practices (and the WoT Best Practices doc should also mention it...).

@mmccool
Copy link
Contributor Author

mmccool commented Feb 7, 2022

please also consider #1363

Done

@mmccool
Copy link
Contributor Author

mmccool commented Feb 7, 2022

@j1y3p4rk I updated 9.1 and 9.2 to include your input. Indeed use of encryption (secure channels) was what I meant... However, upon reviewing 9.2 I'm wondering if we can add another mitigation: if a context URL uses only HTTP, we could recommend that an implementation ATTEMPT to fetch the context file (if needed) from an HTTPS URL instead and only use the HTTP one if absolutely necessary. Is that a reasonable thing to add here?

@mmccool
Copy link
Contributor Author

mmccool commented Feb 7, 2022

I went ahead and added the following sentence to the end of 9.2:
"If it is necessary to fetch a context file, an implementation may also attempt to use HTTPS (HTTP over TLS) even when only an HTTP URL is given."
Please comment if you feel this is a bad idea and I can revert. A lot of the time use of an HTTP URL is just a convention (a standardized "name" for the context) and when actually fetching content is it expected/permitted to upgrade security measures.

@mmccool
Copy link
Contributor Author

mmccool commented Feb 7, 2022

I wonder also if somewhere in the TD spec (need to check if the JSON-LD spec already says this) it should say that HTTP and HTTPS URLs, if otherwise the same, are assumed to describe the same context. Note the TD spec itself uses HTTPS context URLs (and really, we do want to avoid downgrading that to HTTP by accident, so a validator should reject HTTP versions, so this has to be worded that an upgrade is permitted, not that they are equivalent).

@sebastiankb
Copy link
Contributor

sebastiankb commented Feb 9, 2022

from today's TD call:

  • group decided to merge this PR and have this for the WD
  • it is not completed yet, after the WD release there will be further updates
  • we need to resolve the conflict before before merge, @mmccool work on this and will merge it later

@mmccool
Copy link
Contributor Author

mmccool commented Feb 9, 2022

Please see PR #1387: same content, noise eliminated.

@danielpeintner
Copy link
Contributor

Shall this PR be closed since #1387 has been merged?

@mmccool
Copy link
Contributor Author

mmccool commented Feb 16, 2022

Closing, replaced with PR #1387

@mmccool mmccool closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split "9. Security and Privacy Considerations" into two sections? Review Security and Privacy Considerations
4 participants